This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: error when running "make bench"
- From: Joseph Myers <joseph at codesourcery dot com>
- To: paul zimmermann <Paul dot Zimmermann at inria dot fr>
- Cc: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>, <carlos at redhat dot com>, <nd at arm dot com>, <libc-alpha at sourceware dot org>
- Date: Thu, 16 Jan 2020 16:31:05 +0000
- Subject: Re: error when running "make bench"
- Ironport-sdr: NZU3jxiv3CVM9+QBXgbHCWGDnxEgoaHS1nMQF60BPyh7LscbcMlGpgaMNwjAenUElB3mbC/Z5h UrjcocXIhf4cmEvG+FdTIkwSiICMeLdIizxx6t7I8lNNdAiQn4smZEZTDDvAOzwYAZJh+c6wvQ yuBVrw8F1lziRazFiZyD6RBhV/O4glMe+Xepawk7HX9eHHQsD0lnVGpgs+Uht+tiFywtiwgKsW hVJ2RemLMO/aG2fXCXVJqoSucnF/4DLQrODaqN/x4qd9+qhLCEE8k4f+hIs75uscG4W4cUsIjU jnI=
- Ironport-sdr: uWJXhm4zgqUpFof5kBsi4gXxYGRq7eiL8MXfs5XK2pReK3EsrXU5pdqklNNqUGNdU2tsgMmEjM RsKmFrP+ubV3RIqniDm0w/+4/1pAUfrpS8powdk8B3GLLAbhJCFKYktq4+PIZ+ROCtV18+5jqK VsjACtp7fZZCyeYbaWFEgVfaAEqADtC/GU9RqZzSh5lO79qczMT8FlmJRoO86ZwJuQBIQFhB2i Mb66CCIPjT9+MWJXKr+Vl7iT5qLp3z+/DDVclx+R+1YuLOh1BeqIxx8DIiucdKIE9kd+asPrzA fMc=
- References: <mwr200mzh5.fsf@tomate.loria.fr> <CAEMqeSqBv=6Y2Xjz430VM5DcxzbMwzaKRv2=rdumLxNw0TiaQw@mail.gmail.com> <mwzhenkhw4.fsf@tomate.loria.fr> <7929b2d6-5609-f5b4-6ef1-4b10ecd164fb@arm.com> <mwk15rn10c.fsf@tomate.loria.fr>
On Thu, 16 Jan 2020, paul zimmermann wrote:
> thank you Szabolcs, this solved the problem.
>
> However, I believe the issue is on the glibc side. Indeed, the
> bench-timing-type is linked with /tmp/lib/ld-linux-x86-64.so.2
> by the glibc Makefile, and that file doesn't exist if "make install"
> was not done (I configured with ./configure --prefix=/tmp).
The normal configuration people generally test with has --prefix=/usr.
However, what this indicates to me is that the call of $(timing-type)
needs to use $(test-via-rtld-prefix). Does this (untested) patch help in
your configuration using --prefix=/tmp?
Run bench-timing-type with newly built libc.
benchtests/timing-type is built with the newly built libc, so should
be run with it like actual tests and benchmarks.
diff --git a/benchtests/Makefile b/benchtests/Makefile
index 99c3fae9bf..71b9565fed 100644
--- a/benchtests/Makefile
+++ b/benchtests/Makefile
@@ -217,7 +217,10 @@ bench-malloc: $(binaries-bench-malloc)
# capable language or tool.
bench-func: $(binaries-bench)
if [ -n '$^' ] ; then \
- { timing_type=$$($(timing-type)); \
+ { timing_type=$$($(test-wrapper-env) \
+ $(run-program-env) \
+ $(test-via-rtld-prefix) \
+ $(timing-type)); \
echo "{\"timing_type\": \"$${timing_type}\","; \
echo " \"functions\": {"; \
for run in $^; do \
--
Joseph S. Myers
joseph@codesourcery.com