This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 06/16] linux: Consolidate Linux gettimeofday
- From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Thu, 2 Jan 2020 17:37:41 +0530
- Subject: Re: [PATCH 06/16] linux: Consolidate Linux gettimeofday
- References: <20191217214728.2886-1-adhemerval.zanella@linaro.org> <20191217214728.2886-6-adhemerval.zanella@linaro.org>
On 18/12/19 3:17 am, Adhemerval Zanella wrote:
> The IFUNC bypass to vDSO is used when USE_IFUNC_GETTIMEOFDAY is set.
> Currently aarch64, powerpc*, and x86 defines it. Otherwise the
> generic implementation is used, which calls clock_gettime.
>
> Checked on aarch64-linux-gnu, powerpc64le-linux-gnu,
> powerpc64-linux-gnu, powerpc-linux-gnu-power4, x86_64-linux-gnu,
> and i686-linux-gnu.
> ---
> .../unix/sysv/linux/aarch64/gettimeofday.c | 38 +------------
> sysdeps/unix/sysv/linux/gettimeofday.c | 57 +++++++++++++++++++
> .../unix/sysv/linux/powerpc/gettimeofday.c | 35 +-----------
> sysdeps/unix/sysv/linux/x86/gettimeofday.c | 33 +----------
> 4 files changed, 63 insertions(+), 100 deletions(-)
> create mode 100644 sysdeps/unix/sysv/linux/gettimeofday.c
>
OK assuming you've fixed Andreas' review comment.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>