This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix __libc_signal_block_all on sparc64



On 09/12/2019 09:53, Andreas Schwab wrote:
> On Dez 09 2019, Adhemerval Zanella wrote:
> 
>> On 09/12/2019 08:59, Andreas Schwab wrote:
>>> On Dez 09 2019, Adhemerval Zanella wrote:
>>>
>>>> On 09/12/2019 08:00, Andreas Schwab wrote:
>>>>> On Dez 05 2019, Adhemerval Zanella wrote:
>>>>>
>>>>>> Where SIGALL_SET is defined as:
>>>>>>
>>>>>>   ((__sigset_t) { .__val = {[0 ...  _SIGSET_NWORDS-1 ] =  -1 } })
>>>>>
>>>>> Why is that not const?
>>>>>
>>>>> Andreas.
>>>>>
>>>>
>>>> It is on the updated version [1].
>>>
>>> Does it help to make it const?
>>>
>>
>> It does, that's the main reason for the updated version
> 
> No, I mean without the other changes.
> 

The const fixes the issues, the other changes on [1] are essentially 
changing __libc_signal_ to return void.

[1] https://sourceware.org/ml/libc-alpha/2019-12/msg00190.html


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]