This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH v3 2/3] elf: avoid redundant sort in dlopen
- From: David Kilroy <David dot Kilroy at arm dot com>
- To: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Tue, 3 Dec 2019 17:30:11 +0000
- Subject: [PATCH v3 2/3] elf: avoid redundant sort in dlopen
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9H9O+XtCay8hCLI7vMna1/i3HZSdUw1h4yR8ZYmLve0=; b=Ekf1kEiWWLISfsIeKgWZYZMS1sYDrNiQlsDc8Un45O+m/5Atec80BjMvlGQeKLLOcHDMsCnBFBjbkzMTh/H/yKU8mA7M3BgnmOBLntTBrabjTe1e3M75cknB851s1a7pfHeTCsuT7QC9A6vUwB+pzMLSesgiSEFWaIcLWMTKjLNV0dZSOKpLorympXOV+jIQ3IqEDPawnaYfDjdjHSvzTfjiz5lKXYGVftO0AlW4jGhidpq368Umd/CDwufczQijkv17bT2SwV3BMYEikHZ8O0bhMrQU4agb+P+VmcwhoHPJEyd6oXrkkyH2e5mldN4sB/JTHbLRZ4as7tJcD2L9Dw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OoBcdohWe9f30Ys0/5+Uzi9sLGT54KSN5xl4bVr5S0JFpwT2AGSQZf0/w4RZRgyEADmWv2vj4/NstoiYmkfWiEQEyfzRRVYunFODoT6e5W0m5zZAGKXov8SK6UZIHxFLLoV2VDb8hmBoZsm9f+i0d2YIUx9Xp2J3yY8Y0FQtQZdxrcrQKlPV9hEBGzMxsuzuQ/7b4ARDfIOD4pKrCUvLPx4/wAEb0rS3S1zPN/zs0jfzVZsYuLxOnWFrOmrvPRHabUDjS2bgZmHcSu9R+o3zTox2NZiWT1lzYteSCWu3mwGlB6V1qu4J015d5jMMX0wrHCvPVAoy1V/rFkkc4txL9Q==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=David dot Kilroy at arm dot com;
- References: <1575394197-18006-1-git-send-email-david.kilroy@arm.com>
l_initfini is already sorted by dependency in _dl_map_object_deps(),
so avoid sorting again in dl_open_worker().
Tested by running the testsuite on x86_64.
---
elf/dl-open.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/elf/dl-open.c b/elf/dl-open.c
index 9996fe9..c4d09c7c 100644
--- a/elf/dl-open.c
+++ b/elf/dl-open.c
@@ -658,7 +658,6 @@ dl_open_worker (void *a)
l = new->l_initfini[++j];
}
while (l != NULL);
- _dl_sort_maps (maps, nmaps, NULL, false);
int relocation_in_progress = 0;
--
2.7.4