This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 16/30] ldbl-128ibm-compat: Add strfmon_l with IEEE long double format
- From: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>
- To: Paul E Murphy <murphyp at linux dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 3 Dec 2019 13:57:06 -0300
- Subject: Re: [PATCH v2 16/30] ldbl-128ibm-compat: Add strfmon_l with IEEE long double format
- References: <20191025153410.15405-1-gabriel@inconstante.net.br> <20191025153410.15405-17-gabriel@inconstante.net.br> <be221d0d-3ede-ce04-73c7-319efb315fa0@linux.ibm.com> <20191127144305.02f19264@tereshkova>
On Wed, 27 Nov 2019, Gabriel F. T. Gomes wrote:
>On Thu, 14 Nov 2019, Paul E Murphy wrote:
>
>>On 10/25/19 10:33 AM, Gabriel F. T. Gomes wrote:
>>>
>>> +#if __HAVE_DISTINCT_FLOAT128
>>> + _Float128 f128;
>>
>>Nit, should this be a hard tab? Otherwise, OK
>
>Yes, you're right. Fixed locally.
>
>>> + is_binary128 = 0; /* Long double argument by default. */
>>
>>Nit, is the spacing of the comment off here too?
>
>Yes. Also fixed locally.
Now pushed with these changes and fixed copyright years. Thanks!