This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [hurd,commited 1/3] hurd: Fix ld.so link
* Samuel Thibault:
> Florian Weimer, le dim. 01 déc. 2019 19:58:51 +0100, a ecrit:
>> > diff --git a/sysdeps/mach/hurd/Versions b/sysdeps/mach/hurd/Versions
>> > index f69d5fef67..cd148c820f 100644
>> > --- a/sysdeps/mach/hurd/Versions
>> > +++ b/sysdeps/mach/hurd/Versions
>> > @@ -1,7 +1,7 @@
>> > libc {
>> > GLIBC_2.0 {
>> > # functions with a weak definition in the dynamic linker
>> > - __access; __getcwd; __mmap;
>> > + __access; __getcwd; __mmap; __sigprocmask;
>> > }
>>
>> I think I missed the libc update in the patch I posted. But this is
>> wrong, you need to add it to GLIBC_PRIVATE for both libc and ld.
>> Then there will be no abilist update, as expected.
>
> Then it's not only for that symbol, but others from dl-sysdep.c: I just
> followed what was done for the others.
That may be so, but we cannot change the symbol sets for historic
releases. If you really want to use a non-private symbol, it would
have to be at version GLIBC_2.31. But given that it's an internal
interface, GLIBC_PRIVATE is the proper choice.
(Initially, GLIBC_PRIVATE was not used for internal symbols.)