This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Update kernel version to 5.4 in tst-mman-consts.py
- From: Carlos O'Donell <codonell at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
- Date: Thu, 28 Nov 2019 23:52:01 -0500
- Subject: Re: Update kernel version to 5.4 in tst-mman-consts.py
- References: <alpine.DEB.2.21.1911282305510.9015@digraph.polyomino.org.uk>
On 11/28/19 6:06 PM, Joseph Myers wrote:
> This patch updates the kernel version in the test tst-mman-consts.py
> to 5.4. (There are no new constants covered by this test in 5.4 that
> need any other header changes.)
>
> Tested with build-many-glibcs.py.
>
> diff --git a/sysdeps/unix/sysv/linux/tst-mman-consts.py b/sysdeps/unix/sysv/linux/tst-mman-consts.py
> index c11e2ea4ac..3aaf2218f5 100644
> --- a/sysdeps/unix/sysv/linux/tst-mman-consts.py
> +++ b/sysdeps/unix/sysv/linux/tst-mman-consts.py
> @@ -41,7 +41,7 @@ def main():
> help='C compiler (including options) to use')
> args = parser.parse_args()
> linux_version_headers = linux_kernel_version(args.cc)
> - linux_version_glibc = (5, 3)
> + linux_version_glibc = (5, 4)
> sys.exit(glibcextract.compare_macro_consts(
> '#define _GNU_SOURCE 1\n'
> '#include <sys/mman.h>\n',
>
I reviewed kernel 5.4 and also found no new constants that would require
us to adjust the regexp.
I looked specifically at:
./include/linux/mman.h
./include/uapi/asm-generic/mman.h
./include/uapi/linux/mman.h
And also the arch specific mman.h.
I noticed the test doesn't appear to cover PROT_*, MS_*, MADV_*, MCL_*
or PKEY_* constants? Is that an oversight or a conscious choice?
OK for master.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.