This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Setup non-pushing gerrit instance for glibc.
- From: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, Sergio Durigan Junior <sergiodj at redhat dot com>
- Date: Tue, 12 Nov 2019 18:10:02 -0300
- Subject: Re: Setup non-pushing gerrit instance for glibc.
- References: <2e93ece9-386b-c587-9355-33a4695a3f02@redhat.com> <20191112155303.2215a667@tereshkova.br.ibm.com> <1f1bbb12-4121-7243-35f7-dd082fc1c4fd@redhat.com>
Hi, Carlos,
On Tue, 12 Nov 2019, Carlos O'Donell wrote:
>
>On 11/12/19 1:53 PM, Gabriel F. T. Gomes wrote:
>>
>> Simon mentioned [2] a "Quote" (button?). Maybe that is what I wanted and
>> couldn't find.
>
>Highlight, and hit 'c'?
A-ha! So that's how you do it. Thanks!
>> Like others in the community, I think I prefer using email, which gives me
>> freedom to select the amount of quoting and snipping I want, so maybe this
>> will never be a problem to anyone.
>
>Does highlighting and pressing 'c' resolve this for you?
It does.
And replying to comments in the web interface works like email, because I
can edit the quote, so yes, I think this cover the vast majority (if not
all) of the cases where I want to quote and snip.
>The problem with Patchwork is that it never helped with patch review.
>
>Patchwork was simply another way to view the mailing list.
I guess you're right. Patches were piling up, probably because we weren't
using patchwork that much.
>Gerrit today lets me actually complete reviews from start-to-finish and
>can act as an assitance to me.
>
>For example Gerrit already tells me if patches have merge conflicts, so
>I can ignore those or tell people to rebase.
>
>Eventually if we get some ci/cd tied to gerrit it should be really really
>helpful for reviewers.
Right, right. I hope you didn't get me wrong, I like the idea of having
gerrit for glibc and I certainly want to enable more workflows. I am not
against gerrit, and I'm sorry if my comments sounded that way.
Thanks for your comments.