This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Setup non-pushing gerrit instance for glibc.


Hi, Carlos,

On Tue, 12 Nov 2019, Carlos O'Donell wrote:
>
>On 11/12/19 1:53 PM, Gabriel F. T. Gomes wrote:
>> 
>> Simon mentioned [2] a "Quote" (button?).  Maybe that is what I wanted and
>> couldn't find.  
>
>Highlight, and hit 'c'?

A-ha!  So that's how you do it.  Thanks!

>> Like others in the community, I think I prefer using email, which gives me
>> freedom to select the amount of quoting and snipping I want, so maybe this
>> will never be a problem to anyone.  
>
>Does highlighting and pressing 'c' resolve this for you?

It does.

And replying to comments in the web interface works like email, because I
can edit the quote, so yes, I think this cover the vast majority (if not
all) of the cases where I want to quote and snip.

>The problem with Patchwork is that it never helped with patch review.
>
>Patchwork was simply another way to view the mailing list.

I guess you're right.  Patches were piling up, probably because we weren't
using patchwork that much.

>Gerrit today lets me actually complete reviews from start-to-finish and
>can act as an assitance to me.
>
>For example Gerrit already tells me if patches have merge conflicts, so
>I can ignore those or tell people to rebase.
>
>Eventually if we get some ci/cd tied to gerrit it should be really really
>helpful for reviewers.

Right, right.  I hope you didn't get me wrong, I like the idea of having
gerrit for glibc and I certainly want to enable more workflows.  I am not
against gerrit, and I'm sorry if my comments sounded that way.

Thanks for your comments.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]