This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[review v3] Clarify purpose of assert in _dl_lookup_symbol_x
- From: "Carlos O'Donell (Code Review)" <gerrit at gnutoolchain-gerrit dot osci dot io>
- To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
- Cc: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>
- Date: Tue, 12 Nov 2019 12:26:39 -0500
- Subject: [review v3] Clarify purpose of assert in _dl_lookup_symbol_x
- Auto-submitted: auto-generated
- References: <gerrit.1572549639000.I3384349cef90cfd91862ebc34a4053f0c0a99404@gnutoolchain-gerrit.osci.io>
- Reply-to: gnutoolchain-gerrit at osci dot io
Carlos O'Donell has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/glibc/+/469
......................................................................
Patch Set 3:
> Patch Set 2:
>
> > Patch Set 2:
> >
> > (1 comment)
> >
> > I've added you to the glibc-maintainers group, so you can give +2 now as well.
> >
> > (I'm not sure if we can keep up the practice of adding Reviewed-By: lines with Gerrit, because doing so creates a new patch version that needs review.)
>
> Reviewed-By: lines are important for my yearly metrics to see how we as a community are growing and who is reviewing and thanking them.
>
> Let me try something.
I have added my Reviewed-by directly into the bug comment, so that if you push and it matches, then it should be fine.
--
Gerrit-Project: glibc
Gerrit-Branch: master
Gerrit-Change-Id: I3384349cef90cfd91862ebc34a4053f0c0a99404
Gerrit-Change-Number: 469
Gerrit-PatchSet: 3
Gerrit-Owner: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Carlos O'Donell <carlos@redhat.com>
Gerrit-Reviewer: Florian Weimer <fweimer@redhat.com>
Gerrit-Reviewer: Gabriel F. T. Gomes <gabriel@inconstante.net.br>
Gerrit-Comment-Date: Tue, 12 Nov 2019 17:26:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment