This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] math: enhance the endloop condition of function handle_input_flag
- From: Joseph Myers <joseph at codesourcery dot com>
- To: liqingqing <liqingqing3 at huawei dot com>
- Cc: <libc-alpha at sourceware dot org>, <hushiyuan at huawei dot com>, <liusirui at huawei dot com>
- Date: Thu, 7 Nov 2019 00:32:33 +0000
- Subject: Re: [PATCH] math: enhance the endloop condition of function handle_input_flag
- Ironport-sdr: ih3FCyfBkAO4uXGq7T+JliZY+Q9933EX1z0kj4ryWsgisgboDa2ME7PGMKAuUbp5ChlYw9RVPY N6Sqdd/oae9XTx0Qe+/Xw9ys6cC+aqGRDedcFvkJsWs/JXYqaEWM/OvZ+0KpcbpMuLz2sU6jI1 AQA7CWRAcHYpB1q6yfojTACQeQo2s1KEOvEFnHNteZLTu6zATSdLyuvNslU794wvgMSyxLJqHs 4gw6n29h8kJWyy6IoEs+VzBb8zJ0wc4AkPE1oWBtkSS8qp8yXOrgZD/DruDzo/WExeuwVjEdhf gvs=
- Ironport-sdr: wmskgQswlWRweTv5uRGZmZfb6q9n2eGtUei2jeUxM+LoJMk8YYfnGAQfDlUOYPXJdaSy6brEsB tJfR/RxNkPHQ9RZjziTII+6G0/Rq54V/LTwZjkjX+ch97HZNNMWJIh09YTE9nM+Y2sdsWUDPpp cUG+LwAAAfUn0oLPxfS0cCMo58Drt1OtPls9u0lnNswNbcrbWoyZIjlXtTgkj3rQ2C6uslO6Nc NIuOVpzgT13XaBleFn4kE/0FlEb3Umm31JhYd7jjN9WWvYwtejy65u62dsQatu/4WePNO956vd lK0=
- References: <3f569a2a-b8a9-471e-96ed-a94ded8c044b@huawei.com>
On Mon, 28 Oct 2019, liqingqing wrote:
> review the source code of function "handle_input_flag" and found that the
> endloop condition is not correct,
> cause when the loop variable " i " euqal to 16, then the input_flags[16] will
> be out of bounds.
> though I think for now the inputs maybe all right, but just enhanced it.
Thanks, committed with a somewhat edited commit message. Note: I had to
apply the patch manually as it appears your mailer inserted some Unicode
space characters in it. Patches inserted in the body of an email need to
be verbatim with no whitespace changes from the email client for it to be
possible to apply them, so if that's a problem they should be attached
rather than included directly in the body of the email.
--
Joseph S. Myers
joseph@codesourcery.com