This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 02/30] ldbl-128ibm-compat: Add wide character printing functions




On 11/4/19 12:10 PM, Gabriel F. T. Gomes wrote:
Hi, Paul,

On Mon, 04 Nov 2019, Paul E Murphy wrote:

Is it prohibitively difficult to merge the wide character tester with
the one in the previous patch? Otherwise, this looks OK too.

It's not difficult...  In fact, that's how I started it, but it ended up
being too hard to read (imo, anyway), because of the excessive use of
macros and because of the not so nice correspondence between function
names.

I suppose you're suggesting it so that we have less code duplication.
I can make the merge...  It's just not how I would do it.

I can agree with this line of reasoning. I think the tradeoff made by these patches is OK. I don't think these tests will see much change once merged.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]