Re: [PATCH v2 0/4] nptl: Add pthread_clockjoin_np

[Mike Crowe <mac at mcrowe dot com>]

Hi Rafal & Joseph,

On Saturday 02 November 2019 at 00:01:37 +0100, Rafal Luzynski wrote:
> Mike, Adhemerval,
>
> This patch series contains this excerpt:
>
> > commit 69ca4b54c151cec42ccca5e05790efc1a8206b47
> > Author: Mike Crowe <mac@mcrowe.com>
> > Date:   Thu Oct 31 10:03:21 2019 -0300
> >
> >     nptl: Add pthread_clockjoin_np
> >
> >     Introduce pthread_clockjoin_np as a version of pthread_timedjoin_np
> > that
> >     accepts a clockid_t parameter to indicate which clock the timeout
> > should be
> >     measured against. This mirrors the recently-added POSIX-proposed
> > "clock"
> >     wait functions.
> >
> >     Checked on x86_64-linux-gnu.
> >
> >     Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> >
> > diff --git a/NEWS b/NEWS
> > index 75b380c0f8..3006b1a8e4 100644
> > --- a/NEWS
> > +++ b/NEWS
> > @@ -34,6 +34,10 @@ Major new features:
> >    will always receive a 'struct timezone' whose tz_minuteswest and
> >    tz_dsttime fields are zero.
> >
> > +* The function pthread_clockjoin_np has been added, enabling join with a
> > +  terminated thread with an specific clock.  It allows waiting against
>
> I think: "with a specific" -^^
>
> > [...]
> > diff --git a/manual/threads.texi b/manual/threads.texi
> > index c0b504dc1f..e40b55c090 100644
> > --- a/manual/threads.texi
> > +++ b/manual/threads.texi
> > @@ -751,6 +751,18 @@ reached if the thread has not terminated by that time
> > and return
> >  will wait forever in the same way as @code{pthread_join}.
> >  @end deftypefun
> >
> > +@comment pthread.h
> > +@comment GNU extension
> > +@deftypefun int pthread_clockjoin_np (pthread_t *@var{thread},
> > +                                     void **@var{thread_return},
> > +                                      clockid_t @var{clockid},
> > +                                     const struct timespec
> > *@var{abstime})
> > +@standards{GNU, pthread.h}
> > +@safety{@prelim{}@mtsafe{}@asunsafe{@asulock{}}@acunsafe{@aculock{}}}
> > +Behaves like @code{pthread_timedjoin_np} except that time absolute time
> > in
>
> Did you mean "that the absolute"? ----------------------^^^^

I've posted a patch that fixes this, and the hppa-specific
pthread.h change at
https://sourceware.org/ml/libc-alpha/2019-11/msg00020.html .

Thanks for reviewing this.

Mike.