This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 01/11] Linux/Alpha: don't use timeval32 system calls.


On Mon, Oct 28, 2019 at 7:13 PM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
>
>
> On 25/10/2019 22:08, Alistair Francis wrote:
> > On Fri, Oct 25, 2019 at 5:09 AM Adhemerval Zanella
> > <adhemerval.zanella@linaro.org> wrote:
> >>
> >> From: Zack Weinberg <zackw@panix.com>
> >>
> [...]
> >> +
> >> +#include <sys/timex.h>
> >> +#include <sysdep.h>
> >> +
> >> +int
> >> +___adjtimex (struct timex *buf)
> >> +{
> >> +  return INLINE_SYSCALL_CALL (adjtimex, buf);
> >
> > The y2038 safe platforms don't have the adjtimex syscall, instead they
> > have the clock_adjtime call. Can this fall back to clock_adjtime if
> > __NR_adjtimex isn't defined?
> >
> > Alistair
> >
>
> This change is just a direct transformation from the definition at
> syscalls.list (below) to a C implementation.
>
> My plan to add *another* patch on this set to add the specific
> adjtimex refactor to make it call __clock_adjtime instead.

That works for me.

Alistair

>
> >> diff --git a/sysdeps/unix/sysv/linux/syscalls.list b/sysdeps/unix/sysv/linux/syscalls.list
> >> index e374f97b5f..cdcf6c127b 100644
> >> --- a/sysdeps/unix/sysv/linux/syscalls.list
> >> +++ b/sysdeps/unix/sysv/linux/syscalls.list
> >> @@ -1,6 +1,5 @@
> >>  # File name    Caller  Syscall name    Args    Strong name     Weak names
> >>
> >> -adjtimex       adjtime adjtimex        i:p     __adjtimex      adjtimex ntp_adjtime
> >>  alarm          -       alarm           i:i     alarm
> >>  bdflush                EXTRA   bdflush         i:ii    __compat_bdflush        bdflush@GLIBC_2.0:GLIBC_2.23
> >>  capget         EXTRA   capget          i:pp    capget
> >> --
> >> 2.17.1
> >>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]