This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v6 1/2] sysdeps/stat: Handle 64-bit ino_t types on 32-bit hosts
On Tue, Oct 22, 2019 at 3:28 PM Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Tue, 22 Oct 2019, Alistair Francis wrote:
>
> > diff --git a/sysdeps/unix/sysv/linux/generic/stat-check.c b/sysdeps/unix/sysv/linux/generic/stat-check.c
> > new file mode 100644
> > index 00000000000..302d2e8c28a
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/generic/stat-check.c
> > @@ -0,0 +1,29 @@
> > +/* Copyright (C) 2011-2019 Free Software Foundation, Inc.
>
> The new file should have a descriptive comment on its first line, before
I added:
"Static assert for __blkcnt64_t when __INO_T_MATCHES_INO64_T is defined."
> the copyright notice. Copyright dates should be 2019 only (there is no
> copyrightable content in this file copied from older source files).
Fixed
>
> > + This file is part of the GNU C Library.
> > + Contributed by Alistair Francis <alistair.francis@wdc.com> 2019
>
> No "Contributed by" lines in new source files. Contributors should be
> thanked in contrib.texi (with contributions described at the logical level
> rather than listing specific source files).
Removed.
>
> The patch is OK with those fixes.
Thanks Joseph.
Alistair
>
> --
> Joseph S. Myers
> joseph@codesourcery.com