This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] ldd: Print "not a dynamic executable" on standard error [BZ #24150]
* Richard W. M. Jones:
> On Tue, Oct 08, 2019 at 07:01:31PM +0200, Florian Weimer wrote:
>> Tested with the testsuite on x86_64-linux-gnu, and manually.
>>
>> 2019-10-08 Florian Weimer <fweimer@redhat.com>
>>
>> [BZ #24150]
>> * elf/ldd.bash.in: Print "not a dynamic executable" message to
>> standard error.
>>
>> diff --git a/elf/ldd.bash.in b/elf/ldd.bash.in
>> index 843e352a6b..6162004818 100644
>> --- a/elf/ldd.bash.in
>> +++ b/elf/ldd.bash.in
>> @@ -167,7 +167,7 @@ warning: you do not have execution permission for" "\`$file'" >&2
>> 1)
>> # This can be a non-ELF binary or no binary at all.
>> nonelf "$file" || {
>> - echo $" not a dynamic executable"
>> + echo $" not a dynamic executable" >&2
>> result=1
>> }
>
> Yes, finally!
>
> So the patch itself is basically obvious, adding the >&2, therefore:
>
> ACK
>
> Thanks,
Thanks. May I turn this into a Reviewed-By?
Florian