This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 01/21] nptl: Handle EPIPE on tst-cancel2


* Adhemerval Zanella:

> The SIGPIPE can be catched before SIGCANCEL, which makes write fail
> and the thread return an non expected result.
>
> Checked on x86_64-linux-gnu and powerpc64le-linux-gnu.
> ---
>  nptl/tst-cancel2.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/nptl/tst-cancel2.c b/nptl/tst-cancel2.c
> index b22bd496a7..2df2c00578 100644
> --- a/nptl/tst-cancel2.c
> +++ b/nptl/tst-cancel2.c
> @@ -73,9 +73,6 @@ do_test (void)
>        return 1;
>      }
>  
> -  /* This will cause the write in the child to return.  */
> -  close (fd[0]);
> -
>    if (pthread_join (th, &r) != 0)
>      {
>        puts ("join failed");

Commit subject and message no longer match.

nptl/tst-cancel3.c needs the same change, I think.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]