This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND
- From: Christian Brauner <christian dot brauner at ubuntu dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: linux-kernel at vger dot kernel dot org, Oleg Nesterov <oleg at redhat dot com>, libc-alpha at sourceware dot org, Ingo Molnar <mingo at redhat dot com>, Peter Zijlstra <peterz at infradead dot org>, Juri Lelli <juri dot lelli at redhat dot com>, Vincent Guittot <vincent dot guittot at linaro dot org>, Dietmar Eggemann <dietmar dot eggemann at arm dot com>, Steven Rostedt <rostedt at goodmis dot org>, Ben Segall <bsegall at google dot com>, Mel Gorman <mgorman at suse dot de>, Shuah Khan <shuah at kernel dot org>, Andrew Morton <akpm at linux-foundation dot org>, Michal Hocko <mhocko at suse dot com>, Elena Reshetova <elena dot reshetova at intel dot com>, Thomas Gleixner <tglx at linutronix dot de>, Roman Gushchin <guro at fb dot com>, Andrea Arcangeli <aarcange at redhat dot com>, Al Viro <viro at zeniv dot linux dot org dot uk>, Aleksa Sarai <cyphar at cyphar dot com>, "Dmitry V. Levin" <ldv at altlinux dot org>, linux-kselftest at vger dot kernel dot org
- Date: Thu, 10 Oct 2019 17:21:49 +0200
- Subject: Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND
- References: <20191010133518.5420-1-christian.brauner@ubuntu.com> <87d0f4of7j.fsf@oldenburg2.str.redhat.com>
On Thu, Oct 10, 2019 at 04:19:44PM +0200, Florian Weimer wrote:
> * Christian Brauner:
>
> > @@ -2567,7 +2572,7 @@ static bool clone3_args_valid(const struct kernel_clone_args *kargs)
> > * All lower bits of the flag word are taken.
> > * Verify that no other unknown flags are passed along.
> > */
> > - if (kargs->flags & ~CLONE_LEGACY_FLAGS)
> > + if (kargs->flags & ~(CLONE_LEGACY_FLAGS | CLONE3_CLEAR_SIGHAND))
> > return false;
>
> Does the comment need updating? I feel it's a bit misleading now.
Yeah, maybe just:
/* Verify that no unknown flags are passed along. */
?
Thanks!
Christian