This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Make tst-strftime2 depend on locale generation
- From: Tulio Magno Quites Machado Filho <tuliom at ascii dot art dot br>
- To: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>, libc-alpha at sourceware dot org
- Cc: pc at us dot ibm dot com
- Cc:
- Date: Tue, 08 Oct 2019 15:48:33 -0300
- Subject: Re: [PATCH] Make tst-strftime2 depend on locale generation
- References: <20191008174509.22788-1-gabriel@inconstante.net.br>
"Gabriel F. T. Gomes" <gabriel@inconstante.net.br> writes:
> From: "Gabriel F. T. Gomes" <gabrielftg@linux.ibm.com>
>
> Building the test cases in parallel might make tst-strftime2 fail.
> Simply re-running the test case (or building with -j1) makes the problem
> go away. This patch adds the necessary dependency to allow parallel
> builds in the time subdirectory.
>
> Tested for powerpc64le.
LGTM as-is. I confirmed it solves the issue.
Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
> diff --git a/time/Makefile b/time/Makefile
> index b9217992a6..cface6f68a 100644
> --- a/time/Makefile
> +++ b/time/Makefile
> @@ -61,6 +61,7 @@ include ../gen-locales.mk
>
> $(objpfx)tst-ftime_l.out: $(gen-locales)
> $(objpfx)tst-strptime.out: $(gen-locales)
> +$(objpfx)tst-strftime2.out: $(gen-locales)
Likewise for tst-strftime3.out ?
I've never seen an error there, but the test does depend on locales too.
--
Tulio Magno