This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove support for NO_CTORS_DTORS_SECTIONS


* Joseph Myers:

> On Tue, 8 Oct 2019, Florian Weimer wrote:
>
>> As far as I can tell, no architecture currently needs this.  The
>> build-many-glibcs.py logs I have show that the configure check for
>> .ctors/.dtors sections always fails.
>
> I don't think this was meant to be architecture-specific.  It was added in 
> <https://sourceware.org/ml/libc-alpha/2010-12/msg00051.html>; the relevant 
> linker feature appears to have been added in binutils 2.22 (which is older 
> than the oldest supported binutils version for building glibc).

Thanks.  I have changed the commit message to this:

    Remove support for NO_CTORS_DTORS_SECTIONS
    
    This was originally added to support binutils older than version
    2.22:
    
      <https://sourceware.org/ml/libc-alpha/2010-12/msg00051.html>
    
    Since 2.22 is older than the minimum required binutils version
    for building glibc, we no longer need this.  (The changes do
    not impact the statically linked startup code.)
    
    Tested on x86_64-linux-gnu, i686-linux-gnu, s390x-linux-gnu,
    powerpc64le-linux-gnu, aarch64-linux-gnu.  Built with
    build-many-glibcs.py (compilers followed by glibcs).

Okay for master?

Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]