This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: When can we stop writing ChangeLogs?
- From: Carlos O'Donell <carlos at redhat dot com>
- To: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>, Florian Weimer <fweimer at redhat dot com>
- Cc: Siddhesh Poyarekar <siddhesh at gotplt dot org>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Sun, 6 Oct 2019 22:27:08 -0400
- Subject: Re: When can we stop writing ChangeLogs?
- References: <6ebd0e52-a18f-15fc-f4ab-cf2c3afc74e9@gotplt.org> <f656068c-1307-8041-fece-efbb81dfc093@linaro.org> <3bd4b069-e16b-af68-fb2f-17d2458bece5@redhat.com> <e2071ccb-2e31-cea4-84fc-e8353abe0674@gotplt.org> <878sq522xz.fsf@oldenburg2.str.redhat.com> <52634368-ee1e-23d1-1d61-de0057e03829@gotplt.org> <87ftkdzl4v.fsf@oldenburg2.str.redhat.com> <5e38ded2-811f-d5b6-872d-1db24d836576@gotplt.org> <87tv8ty3iv.fsf@oldenburg2.str.redhat.com> <20191003223709.4b6e1c40@tereshkova>
On 10/3/19 9:37 PM, Gabriel F. T. Gomes wrote:
> On Mon, 30 Sep 2019, Florian Weimer wrote:
>
>> * Siddhesh Poyarekar:
>>
>>> On 30/09/19 2:36 pm, Florian Weimer wrote:
>>>> I'm looking for something far simpler here—a script that submitters and
>>>> reviewers can run to see what's going to be committed, and some level of
>>>> project consensus that this is how patches should be posted.
>>>
>>> What kind of scripting are you thinking of? pwclient should be able to
>>> download a patch from patchwork and apply it, giving you an indication
>>> of what a patch is going to look like.
>>
>> The patch isn't the problem. It's the commit subject, author and commit
>> message that I'm after.
>
> Supposing that patches created with git format-patch are posted, which can
> then be applied with git am --scissors, do you foresee any problems with
> Reviewed-by statements and friends? I mean, are you trying to match
> [exactly] the patch on the mailing list with the patch that has been
> actually committed.
The patch *should* conform to git am --scissors for cutting out non-patch
parts.
--
Cheers,
Carlos.