This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4 1/4] lib: introduce copy_struct_from_user() helper
- From: Kees Cook <keescook at chromium dot org>
- To: Christian Brauner <christian dot brauner at ubuntu dot com>
- Cc: Aleksa Sarai <cyphar at cyphar dot com>, Ingo Molnar <mingo at redhat dot com>, Peter Zijlstra <peterz at infradead dot org>, Alexander Shishkin <alexander dot shishkin at linux dot intel dot com>, Jiri Olsa <jolsa at redhat dot com>, Namhyung Kim <namhyung at kernel dot org>, Rasmus Villemoes <linux at rasmusvillemoes dot dk>, Al Viro <viro at zeniv dot linux dot org dot uk>, Linus Torvalds <torvalds at linux-foundation dot org>, libc-alpha at sourceware dot org, linux-api at vger dot kernel dot org, linux-kernel at vger dot kernel dot org
- Date: Tue, 1 Oct 2019 09:28:42 -0700
- Subject: Re: [PATCH v4 1/4] lib: introduce copy_struct_from_user() helper
- References: <20191001011055.19283-1-cyphar@cyphar.com> <20191001011055.19283-2-cyphar@cyphar.com> <201909301856.01255535BD@keescook> <20191001023126.qhzeiwmtoo4agy7t@wittgenstein>
On Tue, Oct 01, 2019 at 04:31:27AM +0200, Christian Brauner wrote:
> On Mon, Sep 30, 2019 at 06:58:39PM -0700, Kees Cook wrote:
> > On Tue, Oct 01, 2019 at 11:10:52AM +1000, Aleksa Sarai wrote:
> > > +static __always_inline
> > > +int copy_struct_from_user(void *dst, size_t ksize,
> > > + const void __user *src, size_t usize)
> >
> > And of course I forgot to realize both this and check_zeroed_user()
> > should also have the __must_check attribute. Sorry for forgetting that
> > earlier!
>
> Just said to Aleksa that I'll just fix this up when I apply so he
> doesn't have to resend. You ok with this, Kees?
Yup; that's totally fine. Thanks!
--
Kees Cook