This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 1/2] Split up endian.h to minimize exposure of BYTE_ORDER.
On Mon, Sep 30, 2019 at 8:25 AM Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Fri, 27 Sep 2019, Alistair Francis wrote:
>
> > - Don't change the networking includes
> > - Don't change the C-SKY Big Endian support
>
> This patch is OK with one change as noted below:
>
> > diff --git a/string/bits/endian.h b/string/bits/endian.h
> > new file mode 100644
> > index 00000000000..ed2ee578c3b
> > --- /dev/null
> > +++ b/string/bits/endian.h
> > @@ -0,0 +1,48 @@
> > +/* Copyright (C) 1992-2019 Free Software Foundation, Inc.
> > + This file is part of the GNU C Library.
>
> This file should have the usual one-line descriptive comment before the
> copyright notice.
I added:
Endian macros for string.h functions
Thanks for the review. I'll push both patches later today if no one
else has any comments.
Alistair
>
> --
> Joseph S. Myers
> joseph@codesourcery.com