This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4] Add helper script for glibc debugging
- From: Arjun Shankar <arjun at redhat dot com>
- To: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>, libc-alpha at sourceware dot org
- Cc: arjun dot is at lostca dot se
- Date: Mon, 30 Sep 2019 13:53:25 +0200
- Subject: Re: [PATCH v4] Add helper script for glibc debugging
- References: <20190927221737.547-1-gabriel@inconstante.net.br>
Hi Gabriel,
Thanks for writing this. The patch looks good to me.
I have one small suggestion. What do you think about this?:
diff --git a/Makefile b/Makefile
index a50fb64dc2..e832034ceb 100644
--- a/Makefile
+++ b/Makefile
@@ -255,8 +255,16 @@ do
-s|--no-symbols-file)
SYMBOLSFILE=false
;;
+ --)
+ shift
+ TESTCASE=$$1
+ COMMANDLINE="$$@"
+ break
+ ;;
*)
TESTCASE=$$1
+ COMMANDLINE="$$@"
+ break
;;
esac
shift
@@ -302,7 +310,7 @@ __ENVVARS__
__SYMBOLSFILE__
break _dl_start_user
run --library-path $(rpath-link):$${BUILD_DIR}/nptl_db \
-__TESTCASE__ __DIRECT__
+__COMMANDLINE__ __DIRECT__
__BREAKPOINTS__
EOF
}
@@ -311,7 +319,7 @@ EOF
template | sed \
-e "s|__ENVVARS__|$$ENVVARSCMD|" \
-e "s|__SYMBOLSFILE__|$$SYMBOLSFILE|" \
- -e "s|__TESTCASE__|$$TESTCASE|" \
+ -e "s|__COMMANDLINE__|$$COMMANDLINE|" \
-e "s|__DIRECT__|$$DIRECT|" \
-e "s|__BREAKPOINTS__|$$BREAKPOINTS|" \
> $$CMD_FILE
The idea being that this will allow invoking (non-testcase) programs with
arguments, like:
./debugglibc.sh -i iconv/iconv_prog -f ASCII -t UTF-8 ascii.txt
I don't necessarily want this patch to go through more versions. It already
adds value and I think it's ready to go in today. Just wanted to enable
another usecase. Perhaps we can discuss it once the current version is in.
Cheers,
Arjun