This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Enable inlining issignalingf within glibc
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Paul A. Clarke" <pc at us dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>, <tuliom at ascii dot art dot br>
- Date: Fri, 27 Sep 2019 21:46:54 +0000
- Subject: Re: [PATCH v2] Enable inlining issignalingf within glibc
- Ironport-sdr: dZIbTQhiG1OfNqCJ1Nc5bFaF4F21wRTZbqkzbIkpbGfPPpYnoiZkMFLr6UaQpvY3Hs7Zldlxk5 9XgLk98Ul5w3vcR+Vs7c78Laej2CvvGJJCAqwdTQV4HrynC7FvqPTXI41mnGGivWo3M0uq6WDC iy/uB4WeS6y+1B3OW8I8Gc1tlqtXwEEPowI/GKulpNFfseB8dN+UqIz9BZS5V1bndb3yQ98bRK 8GMHnjMpjeiNOY5lWqOF2wQW3I/JQfweZs0tsxYfyPgFyQcQM4LiZMFKeRvZg8ulo23REjbnNB 2T8=
- Ironport-sdr: HEciYcjRIlvW052UZDRYtVCIid36LDd5LBCay1Fg3515/EHOT/NGN/5QYY3grMDH6PH6yP/EQA SOxJZUoJexfTkMajRwAcIgsr6xTM8w+Cac2AUESQHz/HWAQtdjpW487xgL0CrwYUB1M5FxciLr 3CmYycoudTVSF+9Ocrj6Tpwd6pLUvk+2lEkorKxBHqOTvajCIlkWfaXFAHI0Pk8jrlKI8sKvZd M/rW4Q8ykR53pPFfocMQKSyE/dz0wp03x0Pz0oR0OnmBfBHuon/H/yT1ZkyKKrKsHJ9TD4aELy OI4=
- References: <1569619615-11714-1-git-send-email-pc@us.ibm.com>
On Fri, 27 Sep 2019, Paul A. Clarke wrote:
> From: "Paul A. Clarke" <pc@us.ibm.com>
>
> issignalingf is a very small function used in some areas where
> better performance (and smaller code) might be helpful.
>
> Establish a means to inline issignalingf, and use that for powerpc.
Please don't add any math_private.h includes for optimizing function
calls, or any optimized definitions of math.h functions that only live in
math_private.h. (Optimized definitions of functions that are only
declared in math_private.h, such as __ieee754_* functions, are OK.)
See my commit c52944e8ccb15158b7e44cbb75fb46d81400d75c. Where code uses
anything from math_private.h, we want it to be something *only* in
math_private.h, so that a build failure results if a math_private.h
include is missing, rather than silently having less optimized code.
I.e. any such optimized inlines belong in include/math.h like the one for
__isinff128 for GCC before GCC 7.
--
Joseph S. Myers
joseph@codesourcery.com