Re: [PATCH v2] Sync "language", "lang_name", "territory", "country_name"

[Rafal Luzynski <digitalfreak at lingonborough dot com>]

18.09.2019 17:19 Mike FABIAN <mfabian@redhat.com> wrote:
> [...]
> From 73086fb8ec38722340ef773061e38c946859fa74 Mon Sep 17 00:00:00 2001
> From: Mike FABIAN <mfabian@redhat.com>
> Date: Tue, 17 Sep 2019 17:20:32 +0200
> Subject: [PATCH] Sync "language", "lang_name", "territory", "country_name"
>  with CLDR/langtable
> 
> Sync these values with CLDR and langtable as much as possible.  Add
> missing values.
> 
> If possible, take the values from CLDR, if CLDR does not have it,
> take it from langtable. The values from langtable which are not from

If you want to put two spaces after a period character then please put
it here as well.

> CLDR are from  Wikipedia or native speakers.
> [...]
> diff --git a/ChangeLog b/ChangeLog
> index 1541a44968..3a7f35846c 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> [...]

I will skip ChangeLog for now, except this line:

> +       * localedata/locales/kab_DZ: Make country_name agree  with CLDR

I think you don't want a double space here.

> [...]
> diff --git a/localedata/locales/be_BY@latin
> b/localedata/locales/be_BY@latin
> index 43b13cc278..fef339f624 100644
> --- a/localedata/locales/be_BY@latin
> +++ b/localedata/locales/be_BY@latin
> @@ -156,7 +156,7 @@ country_ab2 "BY"
>  country_ab3 "BLR"
>  country_num 112
>  country_car    "BY"
> -lang_name    "bie<U0142>aruskaja mova"
> +lang_name    "bie<U0142>aruskaja"
> [...]

This is not my area of expertise but at least this agrees with be_BY
(Cyrillic).

> diff --git a/localedata/locales/ber_DZ b/localedata/locales/ber_DZ
> index 79f3d289b1..4fa1bdfff9 100644
> --- a/localedata/locales/ber_DZ
> +++ b/localedata/locales/ber_DZ
> @@ -8,7 +8,7 @@ escape_char /
>  % exempt you from the conditions of the license if your use would
>  % otherwise be governed by that license.
>  
> -% Amazigh Language Locale for Algeria (latin)
> +% Berber Language Locale for Algeria (latin)

While at this, shouldn't "Latin" be titlecased?

>  % Source:
>  % Contact: Pablo Saratxaga
>  % Email: <pablo@mandrakesoft.com>
> @@ -20,14 +20,14 @@ escape_char /
>  % Users: general
>  
>  LC_IDENTIFICATION
> -title "Amazigh language locale for Algeria (latin)"
> +title "Berber language locale for Algeria (latin)"
> [...]

Same here.

> diff --git a/localedata/locales/ber_MA b/localedata/locales/ber_MA
> index b9bd64868c..5d19354ad6 100644
> --- a/localedata/locales/ber_MA
> +++ b/localedata/locales/ber_MA
> @@ -8,7 +8,7 @@ escape_char /
>  % exempt you from the conditions of the license if your use would
>  % otherwise be governed by that license.
>  
> -% Amazigh Language Locale for Morocco (tifinagh)
> +% Berber Language Locale for Morocco (tifinagh)

I am not sure but the same rule may apply to "Tifinagh".

>  % Source:
>  % Contact: Pablo Saratxaga
>  % Email: <pablo@mandrakesoft.com>
> @@ -20,14 +20,14 @@ escape_char /
>  % Users: general
>  
>  LC_IDENTIFICATION
> -title "Amazigh language locale for Morocco (tifinagh)"
> +title "Berber language locale for Morocco (tifinagh)"

Same here.

> diff --git a/localedata/locales/csb_PL b/localedata/locales/csb_PL
> index c8572f8fc5..662dcefa15 100644
> --- a/localedata/locales/csb_PL
> +++ b/localedata/locales/csb_PL
> @@ -210,6 +210,7 @@ END LC_NAME
>  
>  LC_ADDRESS
>  postal_fmt    "%f%N%a%N%d%N%b%N%s %h %e %r%N%z %T%N%c%N"
> +country_name "P<U00F2>lsk<U00F4>"
> [...]

This is confirmed by a native speaker, thank you.

> diff --git a/localedata/locales/id_ID b/localedata/locales/id_ID
> index 3ddd8d07da..92ff81df23 100644
> --- a/localedata/locales/id_ID
> +++ b/localedata/locales/id_ID
> @@ -155,7 +155,7 @@ country_ab2 "ID"
>  country_ab3 "IDN"
>  country_num 360
>  country_car    "RI"
> -lang_name    "Bahasa Indonesia"
> +lang_name    "Indonesia"
> [...]

I am not sure but I think that this word "Bahasa" appears always
in their language, for example when you choose a language in Anaconda
or in Android.  Maybe it is obligatory?

Please ignore my comment if you have this information from a reliable
source, like CLDR.  If people come and complain you may redirect
them to CLDR.

> diff --git a/localedata/locales/ms_MY b/localedata/locales/ms_MY
> index 275cfbcf27..f49d0c18a6 100644
> --- a/localedata/locales/ms_MY
> +++ b/localedata/locales/ms_MY
> @@ -184,7 +184,7 @@ country_ab3 "MYS"
>  country_num 458
>  country_car "MAL"
>  % Bahasa Melayu
> -lang_name    "Bahasa Melayu"
> +lang_name    "Melayu"
> [...]

This may be the same case.

> diff --git a/localedata/locales/pa_PK b/localedata/locales/pa_PK
> index 1f49bdc90d..0a584114b8 100644
> --- a/localedata/locales/pa_PK
> +++ b/localedata/locales/pa_PK
> @@ -173,7 +173,7 @@ END LC_NAME
>  LC_ADDRESS
>  % FIXME
>  postal_fmt    "%a%N%f%N%d%N%b%N%h %s %e %r%N%T %z%N%c%N"
> -country_name "<U0A2A><U0A3E><U0A15><U0A3F><U0A38><U0A24><U0A3E><U0A28>"
> +country_name "<U067E><U06A9><U0633><U062A><U0627><U0646>"
> [...]

BIG WARNING: This changes the script from Gurmukhi to Arabic.
Is this what you want?

> diff --git a/localedata/locales/szl_PL b/localedata/locales/szl_PL
> index 03e570232d..33db4c4ef5 100644
> --- a/localedata/locales/szl_PL
> +++ b/localedata/locales/szl_PL
> @@ -200,6 +200,7 @@ END LC_NAME
>  
>  LC_ADDRESS
>  postal_fmt    "%f%N%a%N%d%N%b%N%s %h %e %r%N%z %T%N%c%N"
> +country_name "Polska"
> [...]

This is confirmed by a native speaker, thank you.

> diff --git a/localedata/locales/tpi_PG b/localedata/locales/tpi_PG
> index 3315c27633..885481974c 100644
> --- a/localedata/locales/tpi_PG
> +++ b/localedata/locales/tpi_PG
> [...]
> @@ -180,7 +181,7 @@ country_car  "PNG"
>  % https://en.wikipedia.org/wiki/ISO_3166-1_numeric
>  country_num 598
>  % Tok Pisin
> -lang_name    "Tok  Pisin"
> +lang_name    "Tok Pisin"

Good catch, an unnecessary double space.

> diff --git a/localedata/locales/yo_NG b/localedata/locales/yo_NG
> index ec72d078bb..a3102270bf 100644
> --- a/localedata/locales/yo_NG
> +++ b/localedata/locales/yo_NG
> @@ -271,8 +271,8 @@ LC_ADDRESS
>  % "country designation for the <country_post> keyword",
>  % "end of line
>  postal_fmt    "%f%N%a%N%d%N%b%N%s %h %e %r%N%z %T%N%c%N"
> -
> -country_name "Or<U00ED>l<U1EB9><U0301><U00E8>de
> N<U00E0><U00EC>j<U00ED>r<U00ED><U00E0>"
> +% https://yo.wikipedia.org/wiki/N%C3%A0%C3%ACj%C3%ADr%C3%AD%C3%A0 and
> CLDR: Orilẹ̀-èdè Nàìjíríà
> +country_name "Oril<U1EB9><U0300><U002D><U00E8>d<U00E8>
> N<U00E0><U00EC>j<U00ED>r<U00ED><U00E0>"
>  
>  % Language name in Yoruba - "Yorùbá"
>  lang_name     "<U00C8>d<U00E8> Yor<U00F9>b<U00E1>"

While at this, does this close the discussion about
https://sourceware.org/bugzilla/show_bug.cgi?id=24878
and state that the current lang_name in yo_NG is correct?

That's all for now.  I don't give my "Reviewed-by" because I don't
have enough expertise to speak about all these languages except
csb_PL and szl_PL and only because I asked native speakers (experts).

Feel free to collect more feedback from more people.

Regards,

Rafal