This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 2/2] sysdeps/statfs: Handle 64-bit ino_t types on 32-bit hosts


On Wed, 18 Sep 2019, Alistair Francis wrote:

> On a 32-bit platform with a 64-bit ino_t type (__INO_T_MATCHES_INO64_T
> defined) we want to update the statfs struct to remove the padding as it
> isn't required. As we don't have the padding we also need to update the
> overflow checker to not access the undefined members.

I don't think this is anything to do with ino_t (or off_t).  It's actually 
about whether fsblkcnt_t matches fsblkcnt64_t and fsfilcnt_t matches 
fsfilcnt64_t.  It would seem cleanest for those to get their own macros 
saying whether those types match.  Or, more simply, a single macro 
__STATFS_MATCHES_STATFS64.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]