This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add UNSUPPORTED check in elf/tst-pldd.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Stefan Liebler <stli at linux dot ibm dot com>, Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 5 Sep 2019 23:21:01 -0400
- Subject: Re: [PATCH] Add UNSUPPORTED check in elf/tst-pldd.
- References: <fbb0d1e8-4f39-59ed-801c-d53e14d0320a@linux.ibm.com> <d70954b6-e749-5546-bcfd-509a597b8a14@linaro.org> <877e6yiqsn.fsf@oldenburg2.str.redhat.com> <3b9cb5e4-7c9a-c9a4-449e-43ba98a6ad01@linaro.org> <32961942-e67b-c356-a92d-b6e45c8aaf9d@linux.ibm.com> <87blw9fxrp.fsf@oldenburg2.str.redhat.com> <1d419974-c973-c4c1-f1cd-4bbbf8b074f8@linux.ibm.com> <87tva08ijw.fsf@oldenburg2.str.redhat.com> <c6ca1eba-bb9f-c4da-b65c-56f53a04a5f6@linaro.org> <158c26d5-a6cc-37a9-2b23-dc8a45f52217@linux.ibm.com> <b7b2d2bb-a75e-0916-1955-74f1c1747d28@linaro.org>
On 9/3/19 9:34 AM, Adhemerval Zanella wrote:
> Yes, my initial suggestion was just to make it as UNSUPPORTED for
> ptrace_scope >= 1. But I do not oppose adjusting it to run on
> ptrace_scope 1, it is just that the required hackery lead to make it
> somewhat as complex than the test itself.
The flip side of the coin is that the more "UNSUPPORTED" results we
add *implies* there is "one valid way" to setup a glibc test run
and we don't clearly document how to turn all the "UNSUPPORTED"
entries into supported tests?
Stefan's code can at least be refactored into support/ if we need
to do the same thing again in another test.
--
Cheers,
Carlos.