This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC v5 01/21] sunrpc/clnt_udp: Ensure total_deadline is initalised


On Thu, Sep 5, 2019 at 8:22 AM Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Thu, 5 Sep 2019, Jeff Law wrote:
>
> > BTW, has a bug been filed against GCC for the bogus warning?
>
> In this case, it looks like the code is
>
>   if (xargs != NULL)
>     {
>        total_deadline = ...
>     }
>
>   ...
>
>   if (xargs != NULL)
>     {
>       use total_deadline
>     }
>
> (and xargs doesn't get modified in the function and the various gotos in
> this function are all after that setting of total_deadline).  So that
> should be a known issue (and we could consider if the existing comment

That is my understanding as well.

>
>   /* Choose the timeout value.  For non-sending usage (xargs == NULL),
>      the total deadline does not matter, only cu->cu_wait is used
>      below.  */
>
> is sufficient or should be extended to say explicitly the warning is
> bogus).

I was planning on adding a comment in the next version, let me know otherwise.

Alistair

>
> --
> Joseph S. Myers
> joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]