This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] math: Remove const attribute from totalorder* functions
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 5 Sep 2019 15:22:55 +0000
- Subject: Re: [PATCH] math: Remove const attribute from totalorder* functions
- Ironport-sdr: b7gm3ZDz70xLXjKiZGyphiUjmoFuEhYPaY3037ouQYdZ43ddEzT/rtv9S0NakVtJIFndHnkBZZ 1k8ncN7L97tjCjmCwu9skizKzHIqSBR9E6FTS6xpOgpWnlpc6lIyDk07xTcUFoKI0w0U6d7wlS jWNLVH9KnP+LChhcBU1diRQ407kRgar1z70r3IgN9l9Xem1d6tP61d8Sw6rl5XkW1Q/1tPCKJ0 63YtU795TPXt8o9fz55815yhTETtqCwHfrpblpNtFfm2snO8vxVQ70msxkkNd98dV60B/BiKcA ufc=
- Ironport-sdr: KKMzttoYcZFKyznhR4e+8dVPzYfh8Sv4xwadHSE6X6V0iAjLIU83Ms83nuKU8QYRpdl0QRQbmu 7MfBxsf3ig/yDokfaZqWrfrrCryaIvTE1MHvO6BsRPx+4nBW2xp7QQTqHLHiieUpJxDACbZca6 ohLpnS2o5SujkBmMPZKhKR9JhfWjKrPw5y+lnGROPHWz1x6xOKwRRnPiQWRdAkI+Gw+lxwPOEY coicuqd4VONkI0syLDbQEZ2Phg68Typ6654wr7JV6f/5Yz3PkyWrYjTDsFXPrlw9ZGHKy/Rr5Z kPU=
- References: <20190904172219.15244-1-gabriel@inconstante.net.br> <alpine.DEB.2.21.1909041950510.14818@digraph.polyomino.org.uk> <20190905120111.033fe60c@tereshkova> <20190905120714.68e47791@tereshkova>
On Thu, 5 Sep 2019, Gabriel F. T. Gomes wrote:
> On Thu, 05 Sep 2019, Gabriel F. T. Gomes wrote:
>
> >On Wed, 04 Sep 2019, Joseph Myers wrote:
> >
> >>This is OK, but it would be better to replace it with __attribute_pure__
> ~~~~~~~~~~~~~~~~~~
> Oh! Only upon reading my own reply, I noticed the suggestion to use this
> macro, instead of __attribute__ ((__pure__)). Should I go ahead and patch
> it again...
>
> >+__MATHDECL_1 (int, totalorder,, (const _Mdouble_ *__x,
> >+ const _Mdouble_ *__y))
> >+ __attribute__ ((__pure__));
>
> ... replacing '__attribute__ ((__pure__))' with '__attribute_pure__'?
I think it should use __attribute_pure__, yes (although quite likely using
the older compilers for which they differ would show up other problems
with current glibc headers).
--
Joseph S. Myers
joseph@codesourcery.com