This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] math: Remove const attribute from totalorder* functions
On Thu, 05 Sep 2019, Gabriel F. T. Gomes wrote:
>On Wed, 04 Sep 2019, Joseph Myers wrote:
>
>>This is OK, but it would be better to replace it with __attribute_pure__
~~~~~~~~~~~~~~~~~~
Oh! Only upon reading my own reply, I noticed the suggestion to use this
macro, instead of __attribute__ ((__pure__)). Should I go ahead and patch
it again...
>+__MATHDECL_1 (int, totalorder,, (const _Mdouble_ *__x,
>+ const _Mdouble_ *__y))
>+ __attribute__ ((__pure__));
... replacing '__attribute__ ((__pure__))' with '__attribute_pure__'?
> __MATHDECL_1 (int, totalordermag,, (const _Mdouble_ *__x,
> const _Mdouble_ *__y))
>- __attribute__ ((__const__));
>+ __attribute__ ((__pure__));
Likewise, here?
Or it doesn't matter?
Sorry for the oversight.