This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] math: Remove const attribute from totalorder* functions
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Gabriel F. T. Gomes" <gabriel at inconstante dot net dot br>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 4 Sep 2019 19:52:14 +0000
- Subject: Re: [PATCH] math: Remove const attribute from totalorder* functions
- Ironport-sdr: u1ZIjWIVPP9RJOT+GoAqI4sKk8xz2RoqzA3l+Rfr8IKSBgIjwMO9CbxCPYCVvAZAHpulltDfGY Qjt4CDaLLO1xl95cB7x+VdXgSXdqkTjArMNmd2yNTLYjhSs7e7so5lkD9CbSARYtMnLrtX4GHW /bS0ZibSbwmSecox/vB9ndwnmlgJnrUD4+8x/Z2aspFIFvIdrds0fBUglgQUFsFcVE6837uczp JApeGgA06AzHeR6k7e2K/ajAGBP/GAApIL/6eeWsvEm/jLny328csWfZ+vgUNccDrhHRyFozvD A/c=
- Ironport-sdr: 6sZdgc4dW/vm+YO8FUz3MHzI6/aYwdABlbbKdyb0TNxy+Mr5tSLkiOSEWs+NncDVJxZLqEvAA4 xU6UsPQyCMXaB1wmVlozcXYbZoWUZfgfCTVX03QNHZ4cGIdLSysR0YKcBw1nNi/N67CpzELIbs xNVcTB8KZynVe/AcrD3BGlMdV06edXs5XDfCawdVV+6rwa1lgKVZVXSx0t39GJgh72SyhQBqIb kDdNGEfKBw5aO70UllFBNuNhNvq5OnzVc90JMMLfNiWtEPNJ949wpJF++hNJ/NS37hxDF2KMVG 6Ck=
- References: <20190904172219.15244-1-gabriel@inconstante.net.br>
On Wed, 4 Sep 2019, Gabriel F. T. Gomes wrote:
> This commit removes the const attribute from the declarations of all
> totalorder functions, since the pointed-to data is likely to be changed
> by user code between invocations of totalorder*.
This is OK, but it would be better to replace it with __attribute_pure__
(the patch with that replacement is also OK, if it works).
--
Joseph S. Myers
joseph@codesourcery.com