This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] please document if ENOTSUP == EOPNOTSUPP
- From: Nicolas Boulenguez <nicolas at debian dot org>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: libc-alpha at sourceware dot org, Florian Weimer <fweimer at redhat dot com>
- Date: Fri, 23 Aug 2019 01:41:09 +0200
- Subject: Re: [PATCH] please document if ENOTSUP == EOPNOTSUPP
- References: <20190821150658.GA32668@nicolasthinkpad> <3027116a-0f0e-d392-2493-427a2d37fe04@redhat.com>
> > Author: Florian Weimer <fweimer@redhat.com>
> Florian,
> Are you part-author of these changes?
In case he does not remember, I have added Florian because of the
corrections he suggested in comment 6.
> Please post a v2.
The new patch is available at
https://sourceware.org/bugzilla/attachment.cgi as attachment 11962.
Here are the changes:
--- a/manual_same_errno.diff
+++ b/manual_same_errno.diff
@@ -3,6 +3,7 @@
Forwarded: https://sourceware.org/bugzilla/show_bug.cgi?id=2363
Author: Nicolas Boulenguez <nicolas@debian.org>
Author: Florian Weimer <fweimer@redhat.com>
+Author: Carlos O'Donell <carlos@redhat.com>
--- a/manual/errno.texi
+++ b/manual/errno.texi
@@ -17,10 +18,10 @@
+so they can be used as labels in a @code{switch} statement.
+Your program should not make any other assumptions about
the specific values of these symbolic constants.
-+Moreover, @theglibc{} does two exceptions:
++There are two exceptions to this rule:
+@itemize @bullet
-+@item The values of @code{AGAIN} and @code{EWOULDBLOCK} are the
-+same on every supported operating system.
++@item The values of @code{EAGAIN} and @code{EWOULDBLOCK} are
++equal on every supported operating system.
+@item The values of @code{ENOTSUP} and @code{EOPNOTSUPP} are equal
+on some supported operating systems, for example GNU/Linux.
+@end itemize
@@ -79,7 +80,7 @@
nothing to do for that call.
+
+@strong{Portability Note:} Depending on the operating system, the
-+@code{EOPNOTSUPP} and @code{ENOTSUP} macros may have the same value.
++values of @code{EOPNOTSUPP} and @code{ENOTSUP} may be equal.
+Portable code should check for both errors and treat them the same.
@end deftypevr
@@ -90,7 +91,7 @@
it returns @code{ENOSYS} instead.
+
+@strong{Portability Note:} Depending on the operating system, the
-+@code{EOPNOTSUPP} and @code{ENOTSUP} macros may have the same value.
++values of @code{EOPNOTSUPP} and @code{ENOTSUP} may be equal.
+Portable code should check for both errors and treat them the same.
@end deftypevr