This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 03/12] Don’t use the argument to time.

From: Zack Weinberg <zackw at panix dot com>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Wed, 21 Aug 2019 08:29:27 -0400
Subject: Re: [PATCH 03/12] Don’t use the argument to time.
References: <20190820132152.24100-1-zackw@panix.com> <20190820132152.24100-4-zackw@panix.com> <78536de7-d9cc-f9b6-7269-7185982a43c3@linaro.org>

On Tue, Aug 20, 2019 at 2:08 PM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
> >       * misc/syslog.c (__vsyslog_internal)
> >       * time/getdate.c (__getdate_r)
> >       * time/tst_wcsftime.c (main):
> >       Use return value of time, not its argument.
> >
> >       * string/strfry.c (strfry)
> >       * sysdeps/mach/sleep.c (__sleep):
> >       Remove unnecessary casts of NULL.
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

Committed, thanks.

I removed all of the non-ASCII characters from the commit message to
avoid tangling these changes up with an unrelated policy question.

zw

Follow-Ups:
- Re: [PATCH 03/12] Don’t use the argument to time.
  - From: Rafal Luzynski

References:
- [PATCH 00/12] Y2038 preparation: use clock_[gs]ettime to implement the other time-getting and -setting functions
  - From: Zack Weinberg
- [PATCH 03/12] Don’t use the argument to time.
  - From: Zack Weinberg
- Re: [PATCH 03/12] Don’t use the argument to time.
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]