This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 09/12] Finish move of clock_* functions to libc.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: <libc-alpha at sourceware dot org>, Florian Weimer <fweimer at redhat dot com>, Lukasz Majewski <lukma at denx dot de>, Alistair Francis <alistair23 at gmail dot com>, Stepan Golosunov <stepan at golosunov dot pp dot ru>, Arnd Bergmann <arnd at arndb dot de>
- Date: Tue, 20 Aug 2019 15:13:03 +0000
- Subject: Re: [PATCH 09/12] Finish move of clock_* functions to libc.
- Ironport-sdr: fxDdBwfdxWDEK6VyOCz6IrfdDao2+u/5lsSy3Zyeen/jbNxUqi8vZ0aWRYqLhaKREZXXZmWMiw vCqS92hi0sq2UbwPnW46kpIJ2Kq3Ea3WApd/vNLRgDDNs3ab8O+ir/YIebBK6TjvkK0JPCugL8 jlbLDCNxf5S67MdwYQHAUZ3gcz+4UKyTBvmPhx/gyJqFX3gkcrk67deKF30KNf4R5yt9bwhK8c WK9K1bh+bh3CfaQaU/lU4/zzUQ++ogquLhGYm6gNwegqnRm7JR7k7czDPRN4nJUf11EVzgyR4k QVo=
- Ironport-sdr: bTWrYwG8vbamtalRXMT8LX/Owz18nAVWLOs4GyhKJRmRSatGJetT9VCAQDqyoNwqjt33ayaRkT P0zfh24+w2/LAROizWLSCunVTiHpqyuh990JXQ316r7PbRIDHHX+KXBKFUs8bUwfwPbYMaUhDS XmpFplej5ehtUHOtF4Nlda34Kc2Fh/2NnWBT3VOnxUgWvpwWSaBu7+uZj+wop+qxDBinEMr3tt tAjElGLhhG7GWnG8NW5uDHOTQ/YmgLcaA6ew6uqkxU14gRy1qVz7SCrzRC09QhIC2CstajVoUJ wrs=
- References: <20190820132152.24100-1-zackw@panix.com> <20190820132152.24100-10-zackw@panix.com>
On Tue, 20 Aug 2019, Zack Weinberg wrote:
> In glibc 2.17, the functions clock_getcpuclockid, clock_getres,
> clock_gettime, clock_nanosleep, and clock_settime were moved from
> librt.so to libc.so, leaving compatibility stubs behind. Now that the
> dynamic linker no longer insists on finding versioned symbols in the
> same library that originally defined them, we do not need the stubs
> anymore, and this means we don’t need GLIBC_PRIVATE __-prefix aliases for
> most of the functions anymore either. (clock_gettime is still called
> all over the place internally and therefore still needs one.)
But my understanding is that moving a function to libc like that only
works if libc has the symbol *at the same version* as it had in the
library from which it was removed. And I don't see anything in this patch
to add the older symbol version for these functions to libc (in the
implementation and the ABI test baselines) (so libc would then have these
functions at two symbol versions on most platforms, with both versions
pointing to the same function implementations).
--
Joseph S. Myers
joseph@codesourcery.com