This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC v4 06/24] sysdeps/timespec_get: Use clock_gettime64 if avaliable


On Thu, Aug 15, 2019 at 2:28 PM Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Thu, 15 Aug 2019, Alistair Francis wrote:
>
> > On Thu, Aug 15, 2019 at 2:19 PM Joseph Myers <joseph@codesourcery.com> wrote:
> > >
> > > On Thu, 15 Aug 2019, Alistair Francis wrote:
> > >
> > > > There is no internal header for timespec_get, would you prefer me to
> > > > create one or put the define in time/time.h?
> > >
> > > time/time.h is an installed header, so it mustn't go there.
> > > include/time.h would be fine (it has several such defines, for
> > > __localtime64 etc.).
> >
> > Ok, I have this in include/time.h:
> >
> > #if __TIMESIZE == 64
> > #define timespec_get __timespec_get64
> > #else
>
> That should be the other way round (defining __timespec_get64 to
> timespec_get so that timespec_get gets properly exported from libc).

Ok.

Thanks for your help with this. I'll update the other patches with a
similar style and look at sending a full patch series after running
tests.

Alistair

>
> --
> Joseph S. Myers
> joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]