This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] argp: argp.doc prints incorrectly when it starts with "\v" [BZ #19038]
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Girish Joshi <girish946 at gmail dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 25 Jul 2019 15:33:13 +0000
- Subject: Re: [PATCH] argp: argp.doc prints incorrectly when it starts with "\v" [BZ #19038]
- References: <CALkY8p960_gyY_Q1C+FPKuRYYyBCyp7V=PZpu8XaNW5Mxkxdgg@mail.gmail.com> <871s1bep2u.fsf@oldenburg2.str.redhat.com> <CALkY8p9c7BtRoivZ0wpBP-XDoyNibpQ4Ri4Deyr1aFnafbmhLg@mail.gmail.com> <CALkY8p9wQWyZ=02s11GR76WEnU2=_nam6+q545cRJ7oKnkQSEQ@mail.gmail.com> <CALkY8p9MfnsjOxqXdWGtHsEm-1hQ=Q4wwPkFUVpiYfH+GMVhDA@mail.gmail.com> <CALkY8p8Es6bDy_cArL-EAXL_NQiJu0r+nSF=X26Yw3DxmEzP+w@mail.gmail.com>
On Fri, 5 Jul 2019, Girish Joshi wrote:
> diff --git a/argp/tst-argp-help.c b/argp/tst-argp-help.c
> new file mode 100644
> index 0000000000..3bfeb0219c
> --- /dev/null
> +++ b/argp/tst-argp-help.c
> @@ -0,0 +1,39 @@
> +/* Copyright (C) 2002-2019 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
Are you sure this has copyrightable content dating from 2002?
> + Contributed by Girish Joshi <girish946@gmail.com>, 2019.
We don't put "Contributed by" in any new files, and haven't for several
years.
> + /* Parse and process arguments. */
> + argp_parse(&argp, argc, argv, 0, &remaining, NULL);
Please use GNU style, i.e. space before '('. There are also coding style
issues in the changes to argp-help.c (braces in the wrong place).
I'm not clear how this test verifies that the results are as expected,
i.e. how it ensures that, if the change to argp-help.c is not present, the
test FAILs.
I'm also not clear what the actual issue being fixed is. Please make sure
to include a git-style commit message in any patch submission that
provides a self-contained explanation of the problem and how it is fixed.
> +#define TEST_FUNCTION do_test ()
> +#include "../test-skeleton.c"
New tests should not use the old-style test-skeleton.c. See
support/README-testing.c.
--
Joseph S. Myers
joseph@codesourcery.com