This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nptl: Remove unnecessary forwarding of pthread_cond_clockwait from libc
On Tuesday 23 July 2019 at 15:54:57 -0400, Carlos O'Donell wrote:
> On 7/16/19 2:40 PM, Adhemerval Zanella wrote:
> >
> >
> > On 16/07/2019 11:29, Mike Crowe wrote:
> > > In afe4de7d283ebd88157126c5494ce1796194c16e, I added forwarding functions
> > > from libc to libpthread for __pthread_cond_clockwait and
> > > pthread_cond_clockwait to mirror those for pthread_cond_timedwait. These
> > > are unnecessary[1], since these functions aren't (yet) being called from
> > > within libc itself. Let's remove them.
> > >
> > > * nptl/forward.c: Remove unnecessary __pthread_cond_clockwait and
> > > pthread_cond_clockwait forwarding functions. There are no internal
> > > users, so it is unnecessary to expose these functions in libc.so.
> > > * sysdeps/nptl/pthread-functions.h (pthread_functions): Remove
> > > unnecessary ptr___pthread_cond_clockwait member.
> > > * nptl/nptl-init.c (pthread_functions): Remove assignment of
> > > removed member.
> > >
> > > [1] https://sourceware.org/ml/libc-alpha/2017-10/msg00082.html
> >
> > LGTM, thanks. Sorry I missed it on my reviews. We will need an ack from
> > Carlos to push it upstream in current release status.
> >
> > Reviwed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> >
>
> Just double checking for myself that this is in place now. Thanks.
>
> commit 4a8f6d3155e60c19158208ee14022f04c8b0334d
> Author: Mike Crowe <mac@mcrowe.com>
> Date: Wed Jul 17 14:51:08 2019 -0300
>
> nptl: Remove unnecessary forwarding of pthread_cond_clockwait from libc
> In afe4de7d283ebd88157126c5494ce1796194c16e, I added forwarding functions
> from libc to libpthread for __pthread_cond_clockwait and
> pthread_cond_clockwait to mirror those for pthread_cond_timedwait. These
> are unnecessary[1], since these functions aren't (yet) being called from
> within libc itself. Let's remove them.
> * nptl/forward.c: Remove unnecessary __pthread_cond_clockwait and
> pthread_cond_clockwait forwarding functions. There are no internal
> users, so it is unnecessary to expose these functions in libc.so.
> * sysdeps/nptl/pthread-functions.h (pthread_functions): Remove
> unnecessary ptr___pthread_cond_clockwait member.
> * nptl/nptl-init.c (pthread_functions): Remove assignment of
> removed member.
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> [1] https://sourceware.org/ml/libc-alpha/2017-10/msg00082.html
Adhemerval lander it on master as 4a8f6d3155e60c19158208ee14022f04c8b0334d.
HTH.
Mike.