This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] Added International_Standard_Book_Number (ISBN) for various Locales

From: Carlos O'Donell <carlos at redhat dot com>
To: Rafal Luzynski <digitalfreak at lingonborough dot com>, Akhilesh Kumar <akhilesh dot k at samsung dot com>, libc-alpha at sourceware dot org
Date: Tue, 23 Jul 2019 00:39:22 -0400
Subject: Re: [PATCH v2] Added International_Standard_Book_Number (ISBN) for various Locales
References: <CGME20190722045940epcas5p17b46b1969d4c3c3b404fd807befde8ca@epcas5p1.samsung.com> <1563771566-17592-1-git-send-email-akhilesh.k@samsung.com> <603442331.96985.1563824359271@poczta.nazwa.pl>

On 7/22/19 3:39 PM, Rafal Luzynski wrote:

22.07.2019 06:59 Akhilesh Kumar <akhilesh.k@samsung.com> wrote:


We foud missing ISBN code for various locale. Currently we added ISBN code
for
"Ethiopia” and "Eritrea". Later we will update ISBN code for others too.

Link:
[1] https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups

         [BZ #24817]
         * locales/aa_ER  (country_isbn): Added country_isbn.
         * locales/aa_ET  (country_isbn): Likewise.
         * locales/am_ET  (country_isbn): Likewise.
         * locales/byn_ER (country_isbn): Likewise.
         * locales/gez_ER (country_isbn): Likewise.
         * locales/gez_ET (country_isbn): Likewise.
         * locales/om_ET  (country_isbn): Likewise.
         * locales/sid_ET (country_isbn): Likewise.
         * locales/so_ET  (country_isbn): Likewise.
         * locales/ti_ER  (country_isbn): Likewise.
         * locales/ti_ET  (country_isbn): Likewise.
         * locales/tig_ER (country_isbn): Likewise.
         * locales/wal_ET (country_isbn): Likewise.
---
  localedata/locales/aa_ER  | 3 ++-
  localedata/locales/aa_ET  | 3 ++-
  localedata/locales/am_ET  | 3 ++-
  localedata/locales/byn_ER | 3 ++-
  localedata/locales/gez_ER | 3 ++-
  localedata/locales/gez_ET | 3 ++-
  localedata/locales/om_ET  | 3 ++-
  localedata/locales/sid_ET | 3 ++-
  localedata/locales/so_ET  | 3 ++-
  localedata/locales/ti_ER  | 3 ++-
  localedata/locales/ti_ET  | 3 ++-
  localedata/locales/tig_ER | 3 ++-
  localedata/locales/wal_ET | 3 ++-
  13 files changed, 26 insertions(+), 13 deletions(-)
[...]


Thank you for this contribution, Akhilesh.  There are several new
issues in your patch.  But before I discuss them the major question is:

Carlos, do we want to fix this issue now as we are in the freeze period,
10 days before the next release?


These are new features. I'd like these to wait.

--
Cheers,
Carlos.

References:
- [PATCH v2] Added International_Standard_Book_Number (ISBN) for various Locales
  - From: Akhilesh Kumar
- Re: [PATCH v2] Added International_Standard_Book_Number (ISBN) for various Locales
  - From: Rafal Luzynski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]