This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH glibc] Linux: Include <linux/sockios.h> in <bits/socket.h> under __USE_MISC
- From: Arnd Bergmann <arnd at arndb dot de>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Sergei Trofimovich <slyfox at gentoo dot org>, Networking <netdev at vger dot kernel dot org>, Linux Kernel Mailing List <linux-kernel at vger dot kernel dot org>, "David S. Miller" <davem at davemloft dot net>, Michael Kerrisk <mtk dot manpages at gmail dot com>, linux-man <linux-man at vger dot kernel dot org>
- Date: Mon, 22 Jul 2019 13:34:48 +0200
- Subject: Re: [PATCH glibc] Linux: Include <linux/sockios.h> in <bits/socket.h> under __USE_MISC
- References: <87ftmys3un.fsf@oldenburg2.str.redhat.com>
On Mon, Jul 22, 2019 at 1:31 PM Florian Weimer <fweimer@redhat.com> wrote:
>
> Historically, <asm/socket.h> (which is included from <bits/socket.h>)
> provided ioctl operations for sockets. User code accessed them
> through <sys/socket.h>. The kernel UAPI headers have removed these
> definitions in favor of <linux/sockios.h>. This commit makes them
> available via <sys/socket.h> again.
Looks good to me.
I wonder if we should still do these two changes in the kernel:
- include asm/socket.h from linux/socket.h for consistency
- move the defines that got moved from asm/sockios.h to linux/sockios.h
back to the previous location to help anyone who is user
newer kernel headers with older glibc headers.
Arnd