This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: linux-headers-5.2 and proper use of SIOCGSTAMP
- From: Arnd Bergmann <arnd at arndb dot de>
- To: Florian Weimer <fw at deneb dot enyo dot de>
- Cc: Sergei Trofimovich <slyfox at gentoo dot org>, Networking <netdev at vger dot kernel dot org>, Linux Kernel Mailing List <linux-kernel at vger dot kernel dot org>, GNU C Library <libc-alpha at sourceware dot org>, "David S. Miller" <davem at davemloft dot net>, Michael Kerrisk <mtk dot manpages at gmail dot com>, linux-man <linux-man at vger dot kernel dot org>
- Date: Sat, 20 Jul 2019 20:50:23 +0200
- Subject: Re: linux-headers-5.2 and proper use of SIOCGSTAMP
- References: <20190720174844.4b989d34@sf> <87wogca86l.fsf@mid.deneb.enyo.de>
On Sat, Jul 20, 2019 at 8:10 PM Florian Weimer <fw@deneb.enyo.de> wrote:
>
> * Sergei Trofimovich:
>
> > Should #include <linux/sockios.h> always be included by user app?
> > Or should glibc tweak it's definition of '#include <sys/socket.h>'
> > to make it available on both old and new version of linux headers?
>
> What is the reason for dropping SIOCGSTAMP from <asm/socket.h>?
>
> If we know that, it will be much easier to decide what to do about
> <sys/socket.h>.
As far as I can tell, nobody thought it would be a problem to move it
from asm/sockios.h to linux/sockios.h, as the general rule is that one
should use the linux/*.h version if both exist, and that the asm/*.h
version only contains architecture specific definitions. The new
definition is the same across all architectures, so it made sense to
have it in the common file.
If the assumption was wrong, the obvious solution is to duplicate the
definitions everywhere or move the common parts into
asm-generic/sockios.h, but it would have been better to hear about
that earlier.
Arnd