This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: pthread_cond_clockwait glibc forwarder (was Re: [RFCv4] Add pthread_cond_timedwaitonclock_np)
- From: Mike Crowe <mac at mcrowe dot com>
- To: Florian Weimer <fweimer at redhat dot com>, Carlos O'Donell <carlos at redhat dot com>
- Cc: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Tue, 16 Jul 2019 15:31:10 +0100
- Subject: Re: pthread_cond_clockwait glibc forwarder (was Re: [RFCv4] Add pthread_cond_timedwaitonclock_np)
- References: <20170622170531.1668-1-mac@mcrowe.com> <9ea58c10-ddc7-533e-f477-03e634cb9788@linaro.org> <20170930160124.6il2yexqtv4fojoo@mcrowe.com> <77064c8d-2aa8-4345-0d6d-3a873a5e684f@linaro.org> <20190716100516.fvizo6mhm2hnztxz@mcrowe.com> <8736j6kzvr.fsf@oldenburg2.str.redhat.com>
On Tuesday 16 July 2019 at 13:00:40 +0200, Florian Weimer wrote:
> * Mike Crowe:
>
> > I was digging through some old review comments, and came across this. It
> > looks like I didn't address it. :( afe4de7d283ebd88157126c5494ce1796194c16e
> > added forwarders for __pthread_cond_clockwait and pthread_clock_clockwait
> > to glibc:
> >
> > $ nm /lib64/libc.so.6 |grep _clockwait
> > 000000000007f410 t __pthread_cond_clockwait
> > 000000000007f410 t pthread_cond_clockwait
> >
> > Should we remove them now, before they are included in a release and it's
> > too late? (I tried removing them from forward.c, pthread-functions.h and
> > nptl-init.c and all tests passed on x86_64.)
>
> There's no rush because they aren't part of the ABI due to the missing
> nptl/Versions entry. Therefore, they cannot be used today. Removing
> them is just an optimization.
>
> It's up to Carlos to say whether he wants it in the release. Posting a
> patch should help with that decision (and since there's no ABI list
> change involved, the patch can easily be applied after the release if
> necessary).
Done. https://sourceware.org/ml/libc-alpha/2019-07/msg00298.html
Thanks.
Mike.