This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv8] nss_db: protect against empty mappings
On 7/12/19 6:24 AM, Rafal Luzynski wrote:
12.07.2019 06:21 DJ Delorie <dj@redhat.com> wrote:
If you applied the patch and just ran "make" to rebuild the parts that
changed, it won't update the testroot
Yes, that's exactly what I did.
- you need to either remove the
testroot.pristine directory, or at least remove the
testroot.pristine/install.stamp file.
[...]
Yes, after the full rebuild from scratch all tests pass correctly.
Thank you for explanation and sorry for the noise.
Rafal,
If you think this is a bad developer experience, then please feel
free to voice your concerns.
We're not sure how to get the chroot to be rebuilt easily without
lots of additional cost.
DJ,
I wonder if we can't make the workflow different, an this is purely
a psychological thing:
(a) Make a "build done" stamp.
(b) Compare "build done" stamp with "chroot stamp" and if they are
out of sync, all container tests *run* but have the final exit
code overriden with fail with a new error code which is "OUT OF SYNC"
You can still inspect the original failure code in the logs,
but the container wrapper alters it on return.
(c) Developers see this and can ignore it, but at least the tests
don't run with an erroneous chroot returning results.
(d) Developers must run "make update" to clear this problem, and
the test summary script should indicate this when it see any
"OUT OF SYNC" failures.
Thoughts?
--
Cheers,
Carlos.