This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [glibc] <sys/stat.h>: Use Linux UAPI header for statx if available and useful
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: "Carlos O'Donell" <carlos at redhat dot com>, Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>, nd <nd at arm dot com>, Zack Weinberg <zackw at panix dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 02 Jul 2019 08:54:17 +0200
- Subject: Re: [glibc] <sys/stat.h>: Use Linux UAPI header for statx if available and useful
- References: <20190612110504.66041.qmail@sourceware.org> <87ftoe7utd.fsf@oldenburg2.str.redhat.com> <CAKCAbMj2G7_1bAuE+5X0qvNGMTMN9QenzOpgJmkwC4LK_mrGzA@mail.gmail.com> <87y3266czw.fsf@oldenburg2.str.redhat.com> <c35c19da-b775-3435-d38e-702f30bc6ac3@arm.com> <87ef3y6bpv.fsf@oldenburg2.str.redhat.com> <17fed83c-e000-ccbf-9900-104fc20a6273@arm.com> <874l4u6bad.fsf@oldenburg2.str.redhat.com> <2df99c26-7a4c-02ba-a50e-7557c5581a9b@arm.com> <87muiks0ur.fsf@oldenburg2.str.redhat.com> <368c6bd5-39ec-8ea0-4d86-719158e1acdc@redhat.com> <CAMe9rOoqcVRuCWATCHxH7Uuq6pMEcsVjB7CGviHe+SnvonYWqA@mail.gmail.com>
* H. J. Lu:
>> > diff --git a/sysdeps/unix/sysv/linux/bits/statx.h b/sysdeps/unix/sysv/linux/bits/statx.h
>> > index d36f44efc6..206878723f 100644
>> > --- a/sysdeps/unix/sysv/linux/bits/statx.h
>> > +++ b/sysdeps/unix/sysv/linux/bits/statx.h
>> > @@ -23,8 +23,11 @@
>> > #endif
>> >
>> > /* Use the Linux kernel header if available. */
>> > -#if __glibc_has_include (<linux/stat.h>)
>> > -# include <linux/stat.h>
>> > +
>> > +/* Use "" to work around incorrect macro expansion of the
>> > + __has_include argument (GCC PR 80005). */
>> > +#if __glibc_has_include ("linux/stat.h")
>> > +# include "linux/stat.h"
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> This may have caused:
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=24752
This has also been reported as bug 24532, which predates the commit.
Thanks,
Florian