This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nptl: Add test nptl/tst-pthread-perthread-inherit
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 01 Jul 2019 06:47:14 +0200
- Subject: Re: [PATCH] nptl: Add test nptl/tst-pthread-perthread-inherit
- References: <8736jtlbl6.fsf@oldenburg2.str.redhat.com> <48ae254c-d421-d6e1-6438-22a683c15083@redhat.com> <87sgrra16w.fsf@mid.deneb.enyo.de> <0b095a87-1dfb-eb06-98e9-5154ad24d8a6@redhat.com>
* Carlos O'Donell:
> On 6/30/19 5:10 AM, Florian Weimer wrote:
>> * Carlos O'Donell:
>>
>>>> + NULL attribute at one level, then that is true for both
>>>> + kinds of properties. */
>>>> + if ((outer_perthreadfs == null_attribute)
>>>> + != (outer_perthreadids == null_attribute))
>>>> + continue;
>>>> + if ((inner_perthreadfs == null_attribute)
>>>> + != (inner_perthreadids == null_attribute))
>>>> + continue;
>>>
>>> Do you *have* to exclude these? Could we let the extra tests run?
>>>
>>> Sure they don't make sense, but why do you say they are "impossible?"
>>
>> If threadfs requires a NULL attribute, and threadids requres
>> PTHREAD_PER_THREAD_NP, then we cannot run the subtest because the NULL
>> value does not carry any attributes.
>
> I don't follow.
>
> You have two functions, pthread_attr_setperthreadfs_np, and
> pthread_attr_setperthreadids_np.
>
> You want to call them with the permutation of their options
> and check the results.
>
> At an API level the arguments used to call them are unrelated.
>
> I don't understand what you what to express in the last paragraph.
pthread_create has only one attribute argument. If it is NULL, it
means that both attributes are absent.