This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] nptl: Add test nptl/tst-pthread-perthread-inherit


* Carlos O'Donell:

> On 6/30/19 5:10 AM, Florian Weimer wrote:
>> * Carlos O'Donell:
>> 
>>>> +               NULL attribute at one level, then that is true for both
>>>> +               kinds of properties.  */
>>>> +            if ((outer_perthreadfs == null_attribute)
>>>> +                != (outer_perthreadids == null_attribute))
>>>> +              continue;
>>>> +            if ((inner_perthreadfs == null_attribute)
>>>> +                != (inner_perthreadids == null_attribute))
>>>> +              continue;
>>>
>>> Do you *have* to exclude these? Could we let the extra tests run?
>>>
>>> Sure they don't make sense, but why do you say they are "impossible?"
>> 
>> If threadfs requires a NULL attribute, and threadids requres
>> PTHREAD_PER_THREAD_NP, then we cannot run the subtest because the NULL
>> value does not carry any attributes.
>
> I don't follow.
>
> You have two functions, pthread_attr_setperthreadfs_np, and
> pthread_attr_setperthreadids_np.
>
> You want to call them with the permutation of their options
> and check the results.
>
> At an API level the arguments used to call them are unrelated.
>
> I don't understand what you what to express in the last paragraph.

pthread_create has only one attribute argument.  If it is NULL, it
means that both attributes are absent.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]