This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Replace PREPARE_VERSION macro with inline function
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Tobias Klauser <tklauser at distanz dot ch>
- Cc: libc-alpha at sourceware dot org, Carlos O'Donell <carlos at redhat dot com>
- Date: Fri, 28 Jun 2019 08:48:41 -0300
- Subject: Re: [PATCH] Replace PREPARE_VERSION macro with inline function
- References: <20190524153941.10128-1-tklauser@distanz.ch> <e071e1f8-41e8-135b-5d98-33046e63506a@redhat.com> <20190628090330.45de3qab7zo7y4di@distanz.ch>
On 28/06/2019 06:03, Tobias Klauser wrote:
> Hi Adhemerval
>
> On 2019-06-20 at 16:20:21 +0200, Carlos O'Donell <carlos@redhat.com> wrote:
>> On 5/24/19 11:39 AM, Tobias Klauser wrote:
>>> Suggested by Adhemerval Zanella
>>
>> Adhemerval,
>>
>> Since you made this suggestion I'll let you review :-)
>>
>> Tobias has copyright status with FSF, so we can install this patch.
>
> Are there any changes needed to this patch? The other one
> ("Add missing VDSO_{NAME,HASH}_* macros and use them for
> PREPARE_VERSION_KNOWN", commit 85c748f9ff3db4a7796472f90d4d80e9987b7922)
> was added to the tree, but this one not yet.
>
> Thanks and best regards
> Tobias
LGTM, I have pushed it upstream for you.