This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v5 00/11] nds32 glibc port, v5
- From: Vincent Chen <vincentc at andestech dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "deanbo422 at gmail dot com" <deanbo422 at gmail dot com>, "Che-Wei Chuang (??????)" <cnoize at andestech dot com>
- Date: Sun, 23 Jun 2019 23:14:08 +0800
- Subject: Re: [PATCH v5 00/11] nds32 glibc port, v5
- References: <1561012838-11352-1-git-send-email-vincentc@andestech.com> <87o92rxjr2.fsf@oldenburg2.str.redhat.com>
On Fri, Jun 21, 2019 at 07:25:53PM +0800, Florian Weimer wrote:
> * Vincent Chen:
>
> > 2. misc/tst-syscall-list
> > The reason for the failure is that udftrap is missing from syscall-names.list.
> > This syscall only exists in Linux 5.0 and 5.1 and will be renamed to
> > fp_udfiex_ctrl in Linux 5.2. Should I send a patch which adds udftrap
> > into syscall-names.list, and resend a patch for renaming after the default
> > kernel version in build-many-glibcs.py is changed to 5.2? or I only send one
> > patch which adds fp_udfiex_ctrl to syscall-names.list and note this failed case
> > as a known issue?
>
> We can mention any name we want in syscall-names.list. Users will only
> see SYS_ names that match their kernel headers and their __NR_ names.
> So we can add fp_udfiex_ctrl to the list at any time. I can review a
> patch to that affect if you send it.
>
I get it, but I has a little question. The syscall-names.list is used for
kernel 5.1 and the udftrap has not been renamed to fp_udfiex_ctrl in this version.
Hence the missing system call is udftrap instead of fp_udfiex_ctrl. Could I
temporarily add udftrap to the list ? When syscall-names.list is for kernel 5.2,
I will send another patch to rename udftrap to fp_udfiex_ctrl.
Thanks for your kind help
Regards
Vincent