Re: [PATCH] MIPS support for GNU hash

[Mihailo Stojanović <mihailo dot stojanovic at rt-rk dot com>]

Thank you for the input. The approach I took for dl-lookup.c (defining 
MIPS specific macros in dl-machine.h and using them in 
architecture-independent dl-lookup.c) will not work for 
architecture-independent dl-addr.c, as it must not include dl-machine.h.

These MIPS specific macros could possibly be moved to 
sysdeps/mips/ldsodefs.h, and their generic counterparts moved to 
architecture-independent sysdeps/generic/ldsodefs.h. This way they could 
be accessed by both dl-lookup.c and dl-addr.c. Is this OK? If not, could 
you suggest another approach?

Regards,

Mihailo

On 20.6.19. 17:13, Joseph Myers wrote:
> On Wed, 19 Jun 2019, Mihailo Stojanovic wrote:
>
> >    I kept the new, MIPS specific, dl-addr.c file, though this is
> > something on which I would like comments from the community.
> That's not maintainable.  Situations where one architecture has an
> architecture-specific modified duplicate of an architecture-independent
> file like this have to be avoided, because people will never reliably
> remember to update the architecture-specific copy when changing the
> architecture-independent version.  The general direction in glibc is more
> unification of sources for different architectures, not less.