This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 01/12] m68k: Remove vDSO support


On Jun 14 2019, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:

> 	* sysdeps/unix/sysv/linux/m68k/Makefile (sysdep_routines,
> 	sysdep-rtld-routines): Remove rules.
> 	* sysdeps/unix/sysv/linux/m68k/Versions (libc) [GLIBC_PRIVATE]:
> 	Remove __vdso_atomic_cmpxchg_32 and __vdso_atomic_barrier.
> 	(ld) [GLIBC_PRIVATE]: __rtld___vdso_read_tp,
> 	__rtld___vdso_atomic_cmpxchg_32, and __rtld___vdso_atomic_barrier.
> 	* sysdeps/unix/sysv/linux/m68k/coldfire/atomic-machine.h
> 	(atomic_compare_and_exchange_val_acq, atomic_full_barrier): Remove
> 	vDSO path for SHARED.
> 	* sysdeps/unix/sysv/linux/m68k/init-first.c: Remove file.
> 	* sysdeps/unix/sysv/linux/m68k/libc-m68k-vdso.c: Likewise.
> 	* sysdeps/unix/sysv/linux/m68k/m68k-helpers.S: Likewise.
> 	* sysdeps/unix/sysv/linux/m68k/m68k-vdso.c: Likewise.
> 	* sysdeps/unix/sysv/linux/m68k/m68k-vdso.h: Likewise.
> 	* sysdeps/unix/sysv/linux/m68k/m68k-helpers.c: New file.

Ok.

> diff --git a/sysdeps/unix/sysv/linux/m68k/coldfire/atomic-machine.h b/sysdeps/unix/sysv/linux/m68k/coldfire/atomic-machine.h
> index 7465a98fef..0a2aa9ffa5 100644
> --- a/sysdeps/unix/sysv/linux/m68k/coldfire/atomic-machine.h
> +++ b/sysdeps/unix/sysv/linux/m68k/coldfire/atomic-machine.h

> @@ -86,24 +59,8 @@ typedef uintmax_t uatomic_max_t;
>  	 : "a" (_a0), "d" (_d2), "d" (_d1));				\
>      (__typeof (oldval)) _d0;						\
>    })
> -#endif
>  
> -#ifdef SHARED
> -# define atomic_full_barrier()					 \
> -  ({								 \
> -    void *tmp;							 \
> -								 \
> -    asm ("movel #_GLOBAL_OFFSET_TABLE_@GOTPC, %0\n\t"		 \
> -	 "lea (-6, %pc, %0), %0\n\t"				 \
> -	 "movel " STR_M68K_VDSO_SYMBOL (__vdso_atomic_barrier)	 \
> -	 "@GOT(%0), %0\n\t"					 \
> -	 "movel (%0), %0\n\t"					 \
> -	 "jsr (%0)\n\t"						 \
> -	 : "=&a" (tmp));					 \
> -  })
> -#else
>  # define atomic_full_barrier()				\

Missing unindent.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]