This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] <sys/stat.h>: Use Linux kernel UAPI header if available and useful
* Andreas Schwab:
>>>> I would prefer the static assert to this.
>>>
>>> In any case, the assertion is in the wrong place, since only the
>>> fallback needs it.
>>
>> Only on Linux, we potentially compile against an out-of-tree definition
>> of struct statx, so this is why I added the assert there.
>
> But it's the Linux version that doesn't really care about the size.
>
> statx_generic is really operating on its own, non-changing definition of
> struct statx, and I think that should be made explicit.
So should I move the _Static_assert to statx_generic? It's not clear
what you want me to do.
I can implement the preprocessor hack as well if you want me to.
Thanks,
Florian