This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 08/28] powerpc: generic nearbyint/nearbyintf
- From: "Gabriel F. T. Gomes" <gabriel at inconstante dot eti dot br>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 27 May 2019 17:42:34 -0300
- Subject: Re: [PATCH 08/28] powerpc: generic nearbyint/nearbyintf
- References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> <20190329133529.22523-9-adhemerval.zanella@linaro.org>
On Fri, Mar 29 2019, Adhemerval Zanella wrote:
>
> * sysdeps/powerpc/fpu/round_to_integer.h (set_fenv_mode): Add
> NEARBYINT handling.
> * sysdeps/powerpc/fpu/s_nearbyint.c: New file.
> * sysdeps/powerpc/fpu/s_nearbyintf.c: Likewise.
> * sysdeps/powerpc/powerpc32/fpu/s_nearbyint.S: Remove file.
> * sysdeps/powerpc/powerpc32/fpu/s_nearbyintf.S: Likewise.
> * sysdeps/powerpc/powerpc64/fpu/s_nearbyint.S: Likewise.
> * sysdeps/powerpc/powerpc64/fpu/s_nearbyintf.S: Likewise.
OK.
> + case NEARBYINT:
> + /* Disable FE_INEXACT exception */
> + reset_fpscr_bit (FPSCR_XE);
> + break;
OK. Do not change round direction and disable the inexact exception.
> - mffs fp11
> - mtfsb0 4*cr7+lt /* Disable FE_INEXACT exception */
OK. Behaviour copied to the C implementation.
Looks good to me, thanks.